feat: Add accumulattive PoW functionality to btclightclient #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Jul 6, 2022
aakoshh
reviewed
Jul 6, 2022
aakoshh
reviewed
Jul 6, 2022
| ) | ||
|
|
||
| func CalcWork(header *wire.BlockHeader) *big.Int { | ||
| return blockchain.CalcWork(header.Bits) |
There was a problem hiding this comment.
I can see here that Bits are some compact representation of the difficulty target.
Are you certain that it's the target that needs to be added, and by no means the actual number of zeroes in the hash, right? I guess it makes sense, since discovering a very high number of leading zeroes probably happened by a random accident, rather than more work spent to look for it.
There was a problem hiding this comment.
vitsalis
force-pushed
the
btclightclient-cumpow
branch
from
4da6bfb
to
9b736c8
Compare
KonradStaniec
added a commit
that referenced
this pull request
Oct 25, 2023
* Add query for validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #50
This PR introduces accumulative PoW functionality. It accomplishes this through the addition of a new
hash -> AccPoWstorage which stores the bytes ofbig.Intobjects.When a new header is added, it's accumulative PoW is calculated as the sum of its work (gathered from the
CalcWork(header.Bits)function of btcd) and the accumulated PoW of its parent. If the accumulative PoW of the new header is bigger than the accumulative PoW of the tip of the canonical chain, then the tip is updated.