feat: btclightclient: Abstract the usage of btcd types and store BTCHeaderInfo objects #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Jul 11, 2022
aakoshh
reviewed
Jul 11, 2022
aakoshh
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #57.
It aims to remove the usage of
*wire.BlockHeaderand*chainhash.Hashobjects throughout the codebase and restrict their usage towards only internal type calls. It also includes some minor fixes for queries and optimizations.Considered converting the
heightinto ansdk.Uint, but I believe that the extra complexity defeats the purpose. More specifically, if you look at the types provided bysdk.Uint(used by theworkattribute), it does not have aMustMarshalmethod, addition or comparison is more complex (instead of operators there are functions) etc. Theworkattribute needs to have thesdk.Uinttype due to it corresponding to a*big.Intinstance.