Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the Podfile to reference the Swift 4 version of ReactiveSwift. #18

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Updates the Podfile to reference the Swift 4 version of ReactiveSwift. #18

merged 2 commits into from
Nov 28, 2017

Conversation

zzcgumn
Copy link
Contributor

@zzcgumn zzcgumn commented Nov 27, 2017

No description provided.

@zzcgumn zzcgumn self-assigned this Nov 27, 2017
@zzcgumn zzcgumn requested review from sergdort and andersio November 27, 2017 12:28
sergdort
sergdort approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@sergdort sergdort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andersio
Copy link
Contributor

Carthage?

@zzcgumn zzcgumn requested a review from RuiAAPeres November 28, 2017 13:57
@sergdort sergdort merged commit 77a517c into develop Nov 28, 2017
@dmcrodrigues dmcrodrigues deleted the martin/swift4 branch November 28, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergdort sergdort sergdort approved these changes

@andersio andersio Awaiting requested review from andersio

@RuiAAPeres RuiAAPeres Awaiting requested review from RuiAAPeres

Assignees

@zzcgumn zzcgumn

Labels
enhancement ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzcgumn @andersio @sergdort