feat: in-protocol minimum gas price #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
requested review from
gitferry,
KonradStaniec,
Lazar955 and
RafilxTenfen
SebastianElvis
commented
Sep 30, 2024
Comment on lines
+49
to
+51
| // CheckTxFeeWithGlobalMinGasPrices will enforce the global minimum | ||
| // gas price for all transactions. | ||
| TxFeeChecker: CheckTxFeeWithGlobalMinGasPrices, |
There was a problem hiding this comment.
NOTE: this is the place where min gas price is enforced
|
We should probably update To use the min global default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/babylonlabs-io/pm/issues/49
This PR introduces the in-protocol minimum gas price mechanism, in which the consensus (more specifically the AnteHandler) enforces every tx has to set a gas price at least 0.002 ubbn. The PR also provides relevant tests. The impl closely follows celestiaorg/celestia-app#2985.
In addition, this PR creates a new package
app/anteto abstract out the construction of the AnteHandler for Babylon, following the practice at Celestia.