Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/Better IBC transfer tests #128

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

maurolacy
Copy link
Contributor

Improve IBC coin transfer tests.

@maurolacy maurolacy requested a review from a team as a code owner October 3, 2024 11:27
@maurolacy maurolacy requested review from gitferry, Lazar955, gusin13, SebastianElvis, KonradStaniec and RafilxTenfen and removed request for a team October 3, 2024 11:27
@maurolacy maurolacy changed the title F/ibc transfer tests f/Better IBC transfer tests Oct 3, 2024
test/e2e/ibc_transfer_e2e_test.go Outdated Show resolved Hide resolved
test/e2e/ibc_transfer_e2e_test.go Outdated Show resolved Hide resolved
@RafilxTenfen
Copy link
Contributor

One tip is that osmosis made some IBC testing https://github.com/osmosis-labs/osmosis/blob/main/tests/e2e/e2e_test.go#L154-L172
and we copied most of the e2e testing code from them, so it might make sense to take a look there on what they are testing

@maurolacy
Copy link
Contributor Author

maurolacy commented Oct 3, 2024

)smosis made some IBC testing https://github.com/osmosis-labs/osmosis/blob/main/tests/e2e/e2e_test.go#L154-L172 and we copied most of the e2e testing code from them, so it might make sense to take a look there on what they are testing

Will take a look, thanks.

In the mean time, this is just confirming that

  1. Tests work as expected.
  2. Transferred assets are fungible.
  3. They are converted to the native denom when transferred back.

Which is not bad, and basically what we wanted to confirm.

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this could be also added to main

Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming this!

test/e2e/ibc_transfer_e2e_test.go Show resolved Hide resolved
@maurolacy
Copy link
Contributor Author

this could be also added to main

Will cherry-pick to main after merging.

@maurolacy maurolacy merged commit 3520b05 into base/consumer-chain-support Oct 4, 2024
21 checks passed
@maurolacy maurolacy deleted the f/ibc-transfer-tests branch October 4, 2024 03:26
maurolacy added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants