-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/Better IBC transfer tests #128
Conversation
b2e1259
to
4663ab9
Compare
One tip is that osmosis made some IBC testing https://github.com/osmosis-labs/osmosis/blob/main/tests/e2e/e2e_test.go#L154-L172 |
Will take a look, thanks. In the mean time, this is just confirming that
Which is not bad, and basically what we wanted to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this could be also added to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming this!
Will cherry-pick to |
Improve IBC coin transfer tests.