Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoneconcierge: replace chain ID with client ID for consumers #32

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Aug 27, 2024

Subsumes #22


Fixes https://github.com/babylonlabs-io/pm/issues/12

This PR replaces the chain ID with the client ID for consumers in the BTC timestamping protocol. This is in line with the IBC security model where each IBC light client corresponds to a chain, and with the BTC staking integration implementation.

The PR includes:

  • renaming all chain ID to consumer ID, same as BTC staking integration does
  • using client ID to identify {epoch, finalised} chain info
  • changing all queries, fuzz tests, e2e tests, and doc accordingly

TODO before merging the PR:

  • wait until @gitferry verifies we can do software upgrade with empty DB and updated DB schema

Plan after the PR:

  • Fixing compatiblity with BE/FE (need arch decisions here)

Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SebastianElvis SebastianElvis merged commit 3d713f2 into main Aug 27, 2024
17 checks passed
@SebastianElvis SebastianElvis deleted the fix-zoneconcierge-clientid branch August 27, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants