feat: ADR-23 Update staking parameters structure #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
added
consensus breaking
First from series of prs to implement adr - https://github.com/babylonlabs-io/pm/blob/main/adr/adr-023-update-btcstaking-params.md - updates parameters struct to match the one in adr - fix tests - add utilites to modify params through command line
Comprehensive table driven test suite to check validations on message validation
KonradStaniec
force-pushed
the
feat/adr-23-update-staking-parameters
branch
from
3f52c5d
to
dc01d2b
Compare
- Add parameters upgrade from TGE chain - Add e2e test
KonradStaniec
requested review from
gitferry and
RafilxTenfen
and removed request for
a team
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/babylonlabs-io/pm/issues/19
Implement ADR-23 to make babylon chain parameters compatible with phase-1: