feat(ADR-025): Enable jailing and unjailing #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR partially closes #64 by jailing sluggish finality providers by not assigning voting power to them in the voting power table. In particular, this PR made the following changes: 1. Change the `sluggish` label of a finality provider to `jailed`. 2. Implement `AfterSluggishFinalityProviderDetected` hook in the `x/btcstaking` module to set the label of a finality provider to `jailed`. 3. Introduce `EventJailedFinalityProvider` event as `EventPowerDistUpdate`, which is emitted after a finality provider is jailed. 4. Introduce a new parameter `jail_duration` to `x/finality` (needs to handle upgrade in a separate PR). 5. Introduce a new field `jailed_until` to `FinalityProviderSigningInfo` in `x/finality`, which is calculated as the timestamp of the jailing block plus the `jail_duration` of the parameter. 6. Clear the signing info record of the jailed finality provider and set `jailed_until=jailingBlock.Time.Add(params.JailDuration)`. 7. Within the `BeginBlocker` of the next block, upon `EventJailedFinalityProvider`, record the finality provider public key and do not assign voting power to it. 8. Modify relevant tests
This PR partially closes #64 by introducing `MsgUnjailFinalityProviders` to allow the fp operator to unjail a jailed finality provider after the jailing period is passed. In particular, this PR made the following changes: - introduce `MsgUnjailFinalityProvider`, within the handler: - get signing info and check current block timestamp - call `UnjailFinalityProvider` from the btcstaking module, which - checks fp existence - checks if the fp is jailed - changes the IsJailed flag to false - creats and emits EventUnjailFinalityProvider, which will be consumed in the `BeginBlocker` of the next block - within `BeginBlocker` of the btcstaking module, upon `EventUnjailFinalityProvider` - change the `IsJailed` flag of the finality provider dist info to `false` so that its accumulated delegated value will be transferred to actual voting power - fuzz tests
This is required for upgrading from the TGE chain
gitferry
requested review from
KonradStaniec,
RafilxTenfen,
SebastianElvis,
Lazar955 and
a team
and removed request for
a team
gitferry
added
consensus breaking
SebastianElvis
approved these changes
Sep 19, 2024
SebastianElvis
pushed a commit
that referenced
this pull request
Sep 19, 2024
Closes #64. TODOs: - [x] #65 - [x] #74 - [x] babylonlabs-io/finality-provider#56 - [x] #81 We still need to update the docs, add CLI cmd, and e2e tests but can be done in separate PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64.
TODOs:
We still need to update the docs, add CLI cmd, and e2e tests but can be done in separate PRs