fix: Epoch initial height #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
KonradStaniec,
Lazar955,
SebastianElvis and
RafilxTenfen
and removed request for
a team
x/epoching/keeper/epochs.go
Outdated
Comment on lines
43
to
44
| firstEpoch := types.NewEpoch(1, epochInterval, 1, &header.Time) | ||
| k.setEpochInfo(ctx, 1, &firstEpoch) |
There was a problem hiding this comment.
What's the problem that this tries to address? Upon BeginBlock of block 1 the epoch 1 metadata will be generated, so it seems not necessary to initialise it upon InitGenesis (block 0)
There was a problem hiding this comment.
I also found it might not be necessary. So maybe the point of this pr is to fix the interval of epoch 0?
There was a problem hiding this comment.
Sounds good, so how about we keep L40-41 and remove L42-44?
SebastianElvis
approved these changes
Sep 26, 2024
x/epoching/keeper/epochs.go
Outdated
Comment on lines
43
to
44
| firstEpoch := types.NewEpoch(1, epochInterval, 1, &header.Time) | ||
| k.setEpochInfo(ctx, 1, &firstEpoch) |
There was a problem hiding this comment.
Sounds good, so how about we keep L40-41 and remove L42-44?
gitferry
force-pushed
the
fix/epoch-initial-height
branch
from
ee47f8f
to
0c39fe2
Compare
gitferry
added a commit
that referenced
this pull request
Sep 27, 2024
When we initialize epoch, we should also initialize epoch 1. Otherwise, epoch 0 will be accessed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we initialize epoch, we should also initialize epoch 1. Otherwise, epoch 0 will be accessed