chore: address PR comments

babylonlabs-io · Nov 25, 2024 · 15cb74d · 15cb74d
1 parent fdc155e
commit 15cb74d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/cmd/stakercli/transaction/transactions_test.go b/cmd/stakercli/transaction/transactions_test.go
@@ -186,8 +186,8 @@ func appRunCreatePhase1WithdrawalTx(r *rand.Rand, t *testing.T, app *cli.App, ar
 	return data
 }
 
-func randRange(_ *rand.Rand, minV, maxV int) int {
-	return rand.Intn(maxV+1-minV) + minV
+func randRange(r *rand.Rand, minV, maxV int) int {
+	return r.Intn(maxV+1-minV) + minV
 }
 
 type StakeParameters struct {

diff --git a/itest/testutil/app_cli.go → itest/testutil/appcli.go b/itest/testutil/app_cli.go → itest/testutil/appcli.go
diff --git a/staker/stakerapp.go b/staker/stakerapp.go
@@ -537,6 +537,7 @@ func (app *App) SendPhase1Transaction(
 		return err
 	}
 
+	// pop only works for native segwit address
 	pop, err := app.createPop(stakerAddr)
 	if err != nil {
 		return err