add claim reward modal #543
Open
+115
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supertong
requested review from
totraev,
gbarkhatov,
jrwbabylonlab and
jeremy-babylonlabs
|
I will remove the mocked data and link it with the actual calls |
totraev
requested changes
Dec 23, 2024
| @@ -42,6 +53,8 @@ export function PersonalBalance() { | |||
| return null; | |||
| } | |||
|
|
|||
| const rewardBalance = ubbnToBbn(rewardsQuery.data ?? 0); | |||
There was a problem hiding this comment.
Domain logic inside render function
jeremy-babylonlabs
approved these changes
Dec 23, 2024
|
Discussed on the call. the code improvement of moving domain logic into its own services will be handled later by its own ticket/PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "Claim" button is clicked, the modal in the above image shoud display.
Note: I have place in a few placeholders since I have no idea where to get those value from.
When the "Proceed" button is clicked on the modal, it will send a notification and when the claim action was successful, a success notification will be send after that.
Note: We might need a redesign of the notification banners but I have no idea if the design is ready so I will leave it for now.