-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new flag export only header bytes #13
Conversation
From babylonlabs-io/babylon#4, I understand that we do not want |
integration tests pass locally |
Well, I thought since it was already done I left the option to export all fields and we could use to confirm some values if needed, but if you prefer to remove it I can remove it entirely @gitferry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove work
entirely as the calculation should be done in Babylon side. We can also remove hash
as this can be obtained from the bytes. This leaves height and bytes. If we want to keep the option of having height
, maybe we can have a flag called with-height
other than only-header-bytes
. This way, for preparing upgrade, we don't need to specify any flag
…rafilx/export-headers-only-header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise lgtm, not sure why e2e failed though
CI fixed in #14 |
…rafilx/export-headers-only-header
Created new structure to avoid exporting
params: []
empty as it was before by using thebbnbtclightclienttypes.GenState
as beforeAdd new flag
with-height
tobtc-headers
command