add pagination properly according to json-api #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacarini
force-pushed
the
feature/pagination
branch
from
1acfa00 to
01b49da
Compare
4 tasks
|
@akaKuruma and @rafaellima what is your thoughts about this PR? |
|
|
||
| unless collection.current_page == FIRST_PAGE | ||
| pages[:first] = FIRST_PAGE | ||
| pages[:prev] = collection.current_page - FIRST_PAGE |
There was a problem hiding this comment.
I'm not sure, but I believe that pages[:prev] should be current - 1, not current - FIRST_PAGE. This considering that the FIRST_PAGE value change to 0, the value of the previous page remains current - 1.
There was a problem hiding this comment.
Actually, FIRST_PAGE is 1, You might had misunderstood because of the name.
But I do agree with you that is quite difficult to read, so I've change the name to ONE_PAGE. What do you think?
bacarini
force-pushed
the
feature/pagination
branch
from
01b49da to
10eeb5c
Compare
bacarini
added a commit
that referenced
this pull request
Aug 21, 2015
add pagination properly according to json-api
|
@bacarini kudos 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagination links is not as json-api says it should be. So, this PR is not only to fix that, but also to make it works with
kaminairias well. ❤️ 😄