Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pspm struct2vec test pspm overwrite new default #776

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

4gwe
Copy link
Contributor

@4gwe 4gwe commented Sep 8, 2024

Fixes # .

Changes proposed in this pull request:

  • changed the default of pspm_option "overwrite" to 2 and put the allowed values to 0, 1 and 2
  • wrote a test for pspm_struct2vec

@dominikbach dominikbach added the Approved The pull request has been approved and can be checked and then merged. label Sep 16, 2024
@dominikbach dominikbach merged commit 5012a01 into develop Sep 16, 2024
1 check passed
@dominikbach dominikbach deleted the pspm_struct2vec_test-pspm_overwrite_new_default branch September 16, 2024 11:35
@4gwe 4gwe self-assigned this Sep 18, 2024
@teddychao teddychao removed the Approved The pull request has been approved and can be checked and then merged. label Sep 30, 2024
@teddychao teddychao added this to the v7.0 milestone Sep 30, 2024
@teddychao teddychao mentioned this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants