Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aiohttp ClientSession optional #28

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Make aiohttp ClientSession optional #28

merged 1 commit into from
Apr 21, 2020

Conversation

bachya
Copy link
Owner

@bachya bachya commented Apr 21, 2020

Describe what the PR does:

This PR makes the aiohttp ClientSession an optional parameter when creating an API object.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement New feature or request label Apr 21, 2020
@bachya bachya self-assigned this Apr 21, 2020
@codeclimate
Copy link

codeclimate bot commented Apr 21, 2020

Code Climate has analyzed commit a0779f2 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #28 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          142       148    +6     
=========================================
+ Hits           142       148    +6     
Impacted Files Coverage Δ
aioflo/api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f89c79...a0779f2. Read the comment docs.

@bachya bachya merged commit 6659850 into dev Apr 21, 2020
@bachya bachya deleted the session branch April 21, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant