Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get device information endpoint #30

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

dmulcahey
Copy link
Contributor

Describe what the PR does:
This PR adds the initial device endpoint to the API. The endpoint retrieves device information for a specific device.

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 24, 2020

Sourcery Code Quality Report (beta)

✅  Merging this PR will increase code quality in the affected files by 0.56 out of 10.

Quality metrics Before After Change
Complexity 2.00 1.00 -1.00 🔵
Method Length 72.32 51.64 -20.68 🔵
Quality 8.14 8.70 0.56 🔵
Other metrics Before After Change
Lines 134 182 48
Changed files Quality Before Quality After Quality Change
aioflo/api.py 8.14 8.10 -0.04 🔴
aioflo/device.py 9.70
tests/test_device.py 8.72

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
aioflo/api.py API._request 9 150.84 5.92 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@codeclimate
Copy link

codeclimate bot commented Jul 24, 2020

Code Climate has analyzed commit 54ba8ab and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #30 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         9    +1     
  Lines          148       157    +9     
=========================================
+ Hits           148       157    +9     
Impacted Files Coverage Δ
aioflo/api.py 100.00% <100.00%> (ø)
aioflo/device.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57f347...54ba8ab. Read the comment docs.

Copy link
Owner

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@bachya bachya merged commit 2637191 into bachya:dev Jul 24, 2020
@bachya bachya added the enhancement New feature or request label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants