Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly track ws90_ver value #254

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Explicitly track ws90_ver value #254

merged 2 commits into from
Aug 16, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Aug 15, 2022

Describe what the PR does:

This PR explicitly tracks the ws90_ver value, which is the current firmware of a Wittboy 7-in-1 array.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Aug 15, 2022
@bachya bachya self-assigned this Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #254 (20ba09f) into dev (d4c4bf3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 20ba09f differs from pull request most recent head eb0e494. Consider uploading reports for the commit eb0e494 to get more accurate results

@@            Coverage Diff            @@
##               dev      #254   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1010      1013    +3     
=========================================
+ Hits          1010      1013    +3     
Impacted Files Coverage Δ
ecowitt2mqtt/helpers/publisher/hass.py 100.00% <ø> (ø)
ecowitt2mqtt/const.py 100.00% <100.00%> (ø)
ecowitt2mqtt/data.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit 71ba9ab into dev Aug 16, 2022
@bachya bachya deleted the ws90_ver branch August 16, 2022 00:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant