Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where runtime wouldn't shut down after MQTT error #275

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix bug where runtime wouldn't shut down after MQTT error #275

merged 1 commit into from
Aug 30, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Aug 30, 2022

Describe what the PR does:

We had a bug where, after an MQTT error of any kind, it would be almost impossible to shut down the runtime because of a race condition. This PR fixes it.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Aug 30, 2022
@bachya bachya self-assigned this Aug 30, 2022
@bachya bachya merged commit f2248b8 into dev Aug 30, 2022
@bachya bachya deleted the stop-bug branch August 30, 2022 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bachya bachya

Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bachya