Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Docker Hub build action to include PRs #290

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Adjust Docker Hub build action to include PRs #290

merged 3 commits into from
Sep 19, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Sep 19, 2022

Describe what the PR does:

This PR updates our Docker Hub workflow to publish images of PRs. This will help in a couple of ways:

  1. It'll allow us to update/triage/diagnose Docker issues within a PR (vs. going straight to dev).
  2. For longer-running PRs, it'll allow Docker users to test the PR changes easily.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Sep 19, 2022
@bachya bachya self-assigned this Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #290 (bf8e9e3) into dev (eb076ec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1132      1132           
=========================================
  Hits          1132      1132           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya
Copy link
Owner Author

bachya commented Sep 19, 2022

Confirmed that the push worked as expected:

CleanShot 2022-09-19 at 15 03 26

@bachya bachya merged commit fd8600b into dev Sep 19, 2022
@bachya bachya deleted the docker-prs branch September 19, 2022 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant