Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lay groundwork for dynamic unit selection #324

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Lay groundwork for dynamic unit selection #324

merged 2 commits into from
Oct 14, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 14, 2022

Describe what the PR does:

For #308, this PR lays the groundwork for dynamic unit selection beyond what we currently have.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the maintenance Generic library tasks label Oct 14, 2022
@bachya bachya self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #324 (d5e070c) into dev (6e9eaec) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1470      1516   +46     
=========================================
+ Hits          1470      1516   +46     
Impacted Files Coverage Δ
ecowitt2mqtt/helpers/calculator/__init__.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/humidity.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/illuminance.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/lightning.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/precipitation.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/pressure.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/temperature.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/time.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/uv.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/wind.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit cdc29fd into dev Oct 14, 2022
@bachya bachya deleted the units branch October 14, 2022 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Generic library tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant