Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix percentage-related illuminance conversion bugs #336

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Fix percentage-related illuminance conversion bugs #336

merged 2 commits into from
Oct 16, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 16, 2022

Describe what the PR does:

Attempting to convert from a percent to any other illuminance unit would return nonsensical results. This PR fixes the bugs.

Does this fix a specific issue?

Fixes https://github.com/bachya/ecowitt2mqtt/issues/

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Oct 16, 2022
@bachya bachya self-assigned this Oct 16, 2022
@bachya bachya merged commit df56d76 into dev Oct 16, 2022
@bachya bachya deleted the percent branch October 16, 2022 02:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bachya bachya

Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bachya