Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separate calculated illuminance data point for lux #341

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 16, 2022

Describe what the PR does:

We previously always calculated solarradiation_lux if solarradiation was present. However, now that we have unit conversion, lux is merely an output unit option and shouldn't be a separate sensor.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added breaking change maintenance Generic library tasks labels Oct 16, 2022
@bachya bachya self-assigned this Oct 16, 2022
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #341 (8a1739e) into dev (9366a40) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1486      1482    -4     
=========================================
- Hits          1486      1482    -4     
Impacted Files Coverage Δ
ecowitt2mqtt/const.py 100.00% <ø> (ø)
ecowitt2mqtt/data.py 100.00% <ø> (ø)
ecowitt2mqtt/helpers/publisher/hass.py 100.00% <ø> (ø)
ecowitt2mqtt/helpers/calculator/illuminance.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit 962a5f3 into dev Oct 16, 2022
@bachya bachya deleted the lux-sensor branch October 16, 2022 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Generic library tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant