Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide config option for overriding speed units #346

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Provide config option for overriding speed units #346

merged 1 commit into from
Oct 16, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 16, 2022

Describe what the PR does:

This PR adds to the user-facing portion of #308 and provides a config option to set the unit for speed data points.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Oct 16, 2022
@bachya bachya self-assigned this Oct 16, 2022
@bachya bachya merged commit b3a1799 into dev Oct 16, 2022
@bachya bachya deleted the speed-units branch October 16, 2022 20:15
@bachya bachya mentioned this pull request Oct 16, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bachya bachya

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bachya