Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to manage output data precision #347

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Add config option to manage output data precision #347

merged 3 commits into from
Oct 17, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 17, 2022

Describe what the PR does:

Since the past PRs re: unit conversion started producing units at high precisions, this PR introduces the ability to control that precision via --precision.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Oct 17, 2022
@bachya bachya self-assigned this Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #347 (f1c35a3) into dev (b3a1799) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #347   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1524      1530    +6     
=========================================
+ Hits          1524      1530    +6     
Impacted Files Coverage Δ
ecowitt2mqtt/__main__.py 100.00% <100.00%> (ø)
ecowitt2mqtt/config.py 100.00% <100.00%> (ø)
ecowitt2mqtt/const.py 100.00% <100.00%> (ø)
ecowitt2mqtt/helpers/calculator/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit 720bbfc into dev Oct 17, 2022
@bachya bachya deleted the precision branch October 17, 2022 05:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant