Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't swallow lightning distance calculation errors #351

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Don't swallow lightning distance calculation errors #351

merged 1 commit into from
Oct 18, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Oct 18, 2022

Describe what the PR does:

Since we introduced a new exception for calculations that fail in #350, we should also use it for lightning strike distance (instead of swallowing it).

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the maintenance Generic library tasks label Oct 18, 2022
@bachya bachya self-assigned this Oct 18, 2022
@bachya bachya merged commit 8bccdd8 into dev Oct 18, 2022
@bachya bachya deleted the swallow branch October 18, 2022 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bachya bachya

Labels
maintenance Generic library tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bachya