Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug wherein MQTT loop tasks are not cancelled upon shutdown #776

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Fix bug wherein MQTT loop tasks are not cancelled upon shutdown #776

merged 4 commits into from
Nov 14, 2023

Conversation

bachya
Copy link
Owner

@bachya bachya commented Nov 13, 2023 •
edited
Loading

Describe what the PR does:

It turns out #766 wasn't correct.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Nov 13, 2023
@bachya bachya self-assigned this Nov 13, 2023
@bachya bachya changed the title Fix bug wherein runtime shutdown occurs during MQTT broker disconnection Fix bug wherein MQTT loop tasks are not cancelled upon shutdown Nov 14, 2023
@bachya bachya merged commit b3eabfa into dev Nov 14, 2023
9 checks passed
@bachya bachya deleted the fix-broker-shutdown branch November 14, 2023 01:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bachya bachya

Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bachya