Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CKEditor 40.2.0 #118

Closed
quicksketch opened this issue Dec 13, 2023 · 4 comments · Fixed by #121
Closed

Upgrade to CKEditor 40.2.0 #118

quicksketch opened this issue Dec 13, 2023 · 4 comments · Fixed by #121

Comments

@quicksketch
Copy link
Member

Another minor release came out yesterday that includes a number of fixes and potentially a few API changes that might affect us.

https://github.com/ckeditor/ckeditor5/releases/tag/v40.2.0

@indigoxela
Copy link
Member

indigoxela commented Dec 14, 2023

Wow, they want to deprecate DLL?

What they describe only adds concerns, and doesn't make anything easier for us. No clear description of alternatives (to come).

Does that mean, we have to rethink our current approach (which isn't ideal, but at least it works)?

And even more breaking changes to come in 2024? 🤕

@quicksketch
Copy link
Member Author

Wow, they want to deprecate DLL?

Yeah, I am quite alarmed too. I posted as much here: ckeditor/ckeditor5#15502 (comment)

They came back and said that loading individual plugins separately from the main bundle and being able to load plain-JS plugins were both goals and acknowledged that DLLs were commonly used. But yes, I forsee the approach breaking at some point, then you'll need to have two different forks of plugins. I'm super-annoyed at CKSource.

@indigoxela
Copy link
Member

Anyway, here's a PR with an update to 40.2.0.

None of the changes seem to affect us (neither image nor html-support). And all the bugs are still there. 🤷

A little more testing would be nice, though.

@quicksketch
Copy link
Member Author

Thanks so much @indigoxela. Seems to work well and I couldn't find any new issues. Indeed the linked image/caption issue (#69) persists, but everything seems good to me. I merged your PR. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants