Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PHP 8.2 #121

Closed
indigoxela opened this issue Aug 9, 2023 · 1 comment
Closed

Compatibility with PHP 8.2 #121

indigoxela opened this issue Aug 9, 2023 · 1 comment

Comments

@indigoxela
Copy link
Member

indigoxela commented Aug 9, 2023

Not that bad, most submodules seem compatible, but tricky.

Class TaxonomyVocabulary doesn't allow dynamic properties, but i18n_taxonomy seems to create them.

--- Internationalization: Taxonomy translation (I18nTaxonomyTestCase) ----


Status    Group      Filename          Line    Function                            
-------------------------------------------------------------------------------------------------
Exception Deprecated taxonomy_vocabula 65      __construct()                                                           
    Creation of dynamic property TaxonomyVocabulary::$i18n_mode is deprecated
Exception Deprecated taxonomy_vocabula 65      __construct()                                                           
    Creation of dynamic property TaxonomyVocabulary::$langcode is deprecated
...

Not sure yet, if it's possible to workaround that. i18n_mode and langcode property seem pretty essential.

Or... eventually that's not even a problem, but core stuffs everything from form submission or config into the TaxonomyVocabulary object.

Fun fact: if I enforce only defined properties in TaxonomyVocabulary::construct(), all i18n_taxonomy tests still pass. 🤔

@indigoxela
Copy link
Member Author

With the core fix merged, this module is compatible with 8.2 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant