Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow to automatically publish a new release #14

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

ukriu
Copy link
Contributor

@ukriu ukriu commented Nov 29, 2024

Adds a workflow to automatically release a new release.
Requires update.json's versionCode to be updated to release a new release.
If the versionCode has not been changed, an artifact will be uploaded with the latest module.

README.md Outdated Show resolved Hide resolved
update.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
backslashxx pushed a commit that referenced this pull request Nov 30, 2024
Adds a workflow to automatically release a new release.
Requires update.json's versionCode to be updated to release a new release.
If the versionCode has not been changed, an artifact will be uploaded with the latest module.

squash:
	workflow: create release workflow
	workflow: Fix some bugs

Tested-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
@backslashxx
Copy link
Owner

backslashxx commented Nov 30, 2024

Thanks for your work.
Staged this and it works.
https://github.com/backslashxx/bindhosts_staging/releases

Though, formality concerns.
Will you rebase this without that merge commit that got included?
also without that new version release yet.

Another way around is I do fixes on my side.
you can check here
https://github.com/backslashxx/bindhosts/commits/staging-workflows/

update.json Outdated Show resolved Hide resolved
Copy link
Owner

@backslashxx backslashxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the restore zip with the "workflow: create release workflow" commit
no need to do two commits if you just delete and restore

--
I checked sha256sums so to be honest, its actually fine, they do match, but don't do this type of thing again.

user@7600es:[/tmp]: $ sha512sum module.zip.deleted
b0bb7dc5e10dbe733c809af8b611c250086b94be990b402477f9a4c4410a621e477a3f79082e716b74527be08fb76ab4a7a96506e3f4f26dbf6d0f476125bb8a  module.zip.deleted
user@7600es:[/tmp]: $ sha512sum module.zip.restored
b0bb7dc5e10dbe733c809af8b611c250086b94be990b402477f9a4c4410a621e477a3f79082e716b74527be08fb76ab4a7a96506e3f4f26dbf6d0f476125bb8a  module.zip.restored

@backslashxx backslashxx merged commit 2456856 into backslashxx:master Nov 30, 2024
@ukriu
Copy link
Contributor Author

ukriu commented Nov 30, 2024

Sorry my bad. Should have thought about that before.

@backslashxx
Copy link
Owner

backslashxx commented Nov 30, 2024

Reabsed on top of master and merged!
Thanks for your contribution.

I will now be preparing a release.

@ukriu
Copy link
Contributor Author

ukriu commented Nov 30, 2024

Reabsed on top of master and merged! Thanks for your contribution.

I will now be preparing a release.

When publishing a new version don't forget to change the download link to something like this:

{
  "version": "v1.7.2",
  "versionCode": 172,
  "zipUrl": "https://github.com/backslashxx/bindhosts/releases/latest/download/bindhosts_172.zip",
  "changelog": "https://raw.githubusercontent.com/backslashxx/bindhosts/master/CHANGELOG.md"
}

And do make sure to delete the module.zip after the next release!

@backslashxx
Copy link
Owner

small fixup was needed but it all worked in the end, cheers.

a144d24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants