Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2591

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Update README.md #2591

merged 1 commit into from
Sep 24, 2020

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Sep 24, 2020 •
edited
Loading

API Path missing on non-local deployment

Github auth path has changed onto /api/auth/github and thus readme should be updated.

✔️ Checklist

  • All tests are passing yarn test
  • Screenshots attached (for UI changes)
  • Relevant documentation updated
  • Prettier run on changed files
  • Tests added for new functionality
  • Regression tests added for bug fixes

Update README.md
eea25df 
API Path missing on non-local deployment
@jlind23 jlind23 requested a review from a team as a code owner September 24, 2020 14:06
stefanalund
stefanalund approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@stefanalund stefanalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@stefanalund stefanalund merged commit 7cae755 into backstage:master Sep 24, 2020
@Rugvip
Copy link
Member

Rugvip commented Sep 24, 2020

Derp, I even updated the line above 😅

@jlind23 jlind23 deleted the patch-2 branch March 11, 2021 07:45
@FoolBuildAgent FoolBuildAgent mentioned this pull request Apr 23, 2024
Open
@padraigobrien padraigobrien mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanalund stefanalund stefanalund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlind23 @Rugvip @stefanalund