Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog: fix refetch in offset mode #28304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vinzscam
Copy link
Member

Hey, I just made a Pull Request!

Fixed an issue where the <EntityListProvider /> in offset mode would unnecessarily re-fetch data when the filter didn't change, causing a flicker effect.

Before:

issue.mov

Now:

fixed.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
@vinzscam vinzscam requested review from a team as code owners December 25, 2024 22:02
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Dec 25, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react patch v1.15.0

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@benjdlambert
Copy link
Member

Could this be something to do with the cause for #28255?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants