cost insights: make change.ratio optional #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Vazquez <ryanv@spotify.com>
🦋 Changeset detectedLatest commit: c2abcf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryanvazquez
force-pushed
the
cost-insights-optional-ratio
branch
from
085183d to
c2abcf9
Compare
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Makes
ChangeStatistic.ratiooptional.Reasoning: Often an entity can incur costs in one period but not in another - such as when a new service is started or decommissioned. This results in either the first or last sum of a change aggregation being zero and growth being technically infinite.
This PR makes
ChangeStatistic.ratiooptional. Where a ratio is omitted, growth is considered infinite and cost insights will use theChangeStatistic.amount(which is required) to determine if growth is positive or negative and render the corresponding UI.Cost Overview Chart
Product Insights Card
Cost Growth Indicator omitted
Product Entity Table
Sorts infinite values
Zero percent growth means zero percent growth
✔️ Checklist
Signed-off-byline in the message. (more info)