Skip to content

Commit

Permalink
feat(ingress): add path as property configurable (#196)
Browse files Browse the repository at this point in the history
* feat(ingress): add path as property configurable

Signed-off-by: Jason Diaz G. <jasondiazg@gmail.com>
Signed-off-by: Jason Diaz <jasondiazg@gmail.com>

* fix(docs): Add the correct expected ingress default value in README.md file

Signed-off-by: Jason Diaz <jasondiazg@gmail.com>

* chore(chart-version): Bump chart version to 1.9.5

Signed-off-by: Jason Diaz <jasondiazg@gmail.com>

* fix(schema): Change ingress path examples in chart schema

Signed-off-by: Jason Diaz <jasondiazg@gmail.com>

* chore(chart-version): Bump chart version to 1.9.5 in README.md

---------

Signed-off-by: Jason Diaz G. <jasondiazg@gmail.com>
Signed-off-by: Jason Diaz <jasondiazg@gmail.com>
Co-authored-by: Jason Diaz G <jason.rene.diaz.gonzalez@ericsson.com>
  • Loading branch information
jasondiazg and Jason Diaz G authored Jun 4, 2024
1 parent ddaaa45 commit b77ce14
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.9.4
version: 1.9.5
5 changes: 3 additions & 2 deletions charts/backstage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Backstage Helm Chart

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 1.9.4](https://img.shields.io/badge/Version-1.9.4-informational?style=flat-square)
![Version: 1.9.5](https://img.shields.io/badge/Version-1.9.5-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying a Backstage application
Expand Down Expand Up @@ -157,11 +157,12 @@ Kubernetes: `>= 1.19.0-0`
| global | Global parameters Global Docker image parameters Please, note that this will override the image parameters, including dependencies, configured to use the global value Current available global Docker image parameters: imageRegistry, imagePullSecrets and storageClass | object | See below |
| global.imagePullSecrets | Global Docker registry secret names as an array </br> E.g. `imagePullSecrets: [myRegistryKeySecretName]` | list | `[]` |
| global.imageRegistry | Global Docker image registry | string | `""` |
| ingress | Ingress parameters | object | `{"annotations":{},"className":"","enabled":false,"host":"","tls":{"enabled":false,"secretName":""}}` |
| ingress | Ingress parameters | object | `{"annotations":{},"className":"","enabled":false,"host":"","path":"/","tls":{"enabled":false,"secretName":""}}` |
| ingress.annotations | Additional annotations for the Ingress resource | object | `{}` |
| ingress.className | Name of the IngressClass cluster resource which defines which controller will implement the resource (e.g nginx) | string | `""` |
| ingress.enabled | Enable the creation of the ingress resource | bool | `false` |
| ingress.host | Hostname to be used to expose the route to access the backstage application (e.g: backstage.IP.nip.io) | string | `""` |
| ingress.path | Path to be used to expose the full route to access the backstage application (e.g: IP.nip.io/backstage) | string | `"/"` |
| ingress.tls | Ingress TLS parameters | object | `{"enabled":false,"secretName":""}` |
| ingress.tls.enabled | Enable TLS configuration for the host defined at `ingress.host` parameter | bool | `false` |
| ingress.tls.secretName | The name to which the TLS Secret will be called | string | `""` |
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
- host: {{ include "common.tplvalues.render" ( dict "value" .Values.ingress.host "context" $ ) }}
http:
paths:
- path: /
- path: {{ .Values.ingress.path }}
pathType: Prefix
backend:
service:
Expand Down
8 changes: 8 additions & 0 deletions charts/backstage/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -6100,6 +6100,14 @@
"title": "Hostname to be used to expose the route to access the backstage application.",
"type": "string"
},
"path": {
"default": "/",
"examples": [
"/backstage"
],
"title": "Path to be used to expose the full route to access the backstage application.",
"type": "string"
},
"tls": {
"additionalProperties": false,
"properties": {
Expand Down
8 changes: 8 additions & 0 deletions charts/backstage/values.schema.tmpl.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,14 @@
"backstage.10.0.0.1.nip.io"
]
},
"path": {
"title": "Path to be used to expose the full route to access the backstage application.",
"type": "string",
"default": "/",
"examples": [
"/backstage"
]
},
"tls": {
"title": "Ingress TLS parameters",
"type": "object",
Expand Down
3 changes: 3 additions & 0 deletions charts/backstage/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ ingress:
# -- Hostname to be used to expose the route to access the backstage application (e.g: backstage.IP.nip.io)
host: ""

# -- Path to be used to expose the full route to access the backstage application (e.g: IP.nip.io/backstage)
path: "/"

# -- Ingress TLS parameters
tls:

Expand Down

0 comments on commit b77ce14

Please sign in to comment.