Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readiness/liveness probes #101

Merged
merged 9 commits into from
May 31, 2023
Merged

Add readiness/liveness probes #101

merged 9 commits into from
May 31, 2023

Conversation

jdamata
Copy link
Contributor

@jdamata jdamata commented May 14, 2023

Closes #95

Description of the change

Adds readiness/liveness probes

@jdamata jdamata requested a review from a team as a code owner May 14, 2023 23:07
@ChrisJBurns
Copy link
Contributor

@jdamata As this is a new feature, this should be a minor version bump 👍

tumido
tumido requested changes May 15, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jdamata!

Can you please add a test case into the ci folder?

Other than that I have few formatting and explanation related nits inline.

Otherwise this looks great! 🙂

@jdamata jdamata requested a review from tumido May 15, 2023 15:17
pcc-damatj added 6 commits May 15, 2023 12:22
@pcc-damatj
Add readiness/liveness probes
7a947d8 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
@pcc-damatj
Bump chart yaml version
09f419e 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
@pcc-damatj
Fix linting
f77983d 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
@pcc-damatj
Fix linting
275f574 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
@pcc-damatj
Description in wrong location
766fab5 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
@pcc-damatj
add ci file
d647bc2 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
@jdamata
Copy link
Contributor Author

jdamata commented May 15, 2023

added the ci file. Are these executing in the test github workflow somehow?

tumido
tumido requested changes May 15, 2023
View reviewed changes
@tumido
Copy link
Member

tumido commented May 15, 2023

added the ci file. Are these executing in the test github workflow somehow?

@jdamata yes, you can see that happen right here: https://github.com/backstage/charts/actions/runs/4982772627/jobs/8919025637?pr=101#step:10:489

@jdamata jdamata requested a review from tumido May 15, 2023 19:36
jdamata and others added 2 commits May 23, 2023 14:47
@jdamata
Merge branch 'main' into main
cb43fe7
@pcc-damatj
run precommit
40114f4 
Signed-off-by: damatj <joel.damata@pointclickcare.com>
tumido
tumido approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit d94c8a2 into backstage:main May 31, 2023
This was referenced Oct 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add kubernetes probes
4 participants
@jdamata @ChrisJBurns @tumido @pcc-damatj