-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix name of appConfig configmap #144
bug: fix name of appConfig configmap #144
Conversation
633a733
to
5d91dd0
Compare
I guess the change in readme.md are caused by the newer version of helm-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @coufalja,
Thanks for contributing. I think the fix itself is good, however you'll need to regenerate the README either via pre-commit
or via helm-docs
with the following arguments:
charts/.pre-commit-config.yaml
Lines 6 to 12 in 4625407
args: | |
# Make the tool search for charts only under the ``charts` directory | |
- --chart-search-root=charts | |
# The `./` makes it relative to the chart-search-root set above | |
- --template-files=./_templates.gotmpl | |
# A base filename makes it relative to each chart directory found | |
- --template-files=README.md.gotmpl |
(Btw, an interesting coincidence, we share the same surname and we live in the same city, are we related? 😄 )
Signed-off-by: Jakub Coufal <jakub.coufal@jamf.com>
5d91dd0
to
bd14fc0
Compare
Got it, thanks for pointing that out 👍 |
I don't think we are but interesting coincidence nevertheless 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Description of the change
Scope the name of generated config map to reflect potential name overrides, currently it is impossible to install 2 instances in a single namespace.
Existing or Associated Issue(s)
N/A
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.