Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix name of appConfig configmap #144

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

coufalja
Copy link
Contributor

@coufalja coufalja commented Oct 23, 2023

Description of the change

Scope the name of generated config map to reflect potential name overrides, currently it is impossible to install 2 instances in a single namespace.

Existing or Associated Issue(s)

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@coufalja coufalja requested a review from a team as a code owner October 23, 2023 12:50
@coufalja coufalja force-pushed the bug/respect-cfg-map-name-override branch 2 times, most recently from 633a733 to 5d91dd0 Compare October 23, 2023 13:00
@coufalja
Copy link
Contributor Author

I guess the change in readme.md are caused by the newer version of helm-docs

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coufalja,

Thanks for contributing. I think the fix itself is good, however you'll need to regenerate the README either via pre-commit or via helm-docs with the following arguments:

args:
# Make the tool search for charts only under the ``charts` directory
- --chart-search-root=charts
# The `./` makes it relative to the chart-search-root set above
- --template-files=./_templates.gotmpl
# A base filename makes it relative to each chart directory found
- --template-files=README.md.gotmpl

(Btw, an interesting coincidence, we share the same surname and we live in the same city, are we related? 😄 )

Signed-off-by: Jakub Coufal <jakub.coufal@jamf.com>
@coufalja coufalja force-pushed the bug/respect-cfg-map-name-override branch from 5d91dd0 to bd14fc0 Compare October 24, 2023 12:03
@coufalja coufalja requested a review from tumido October 24, 2023 12:04
@coufalja
Copy link
Contributor Author

Got it, thanks for pointing that out 👍

@coufalja
Copy link
Contributor Author

coufalja commented Oct 24, 2023

(Btw, an interesting coincidence, we share the same surname and we live in the same city, are we related? 😄 )

I don't think we are but interesting coincidence nevertheless 😄

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit 640ce6c into backstage:main Oct 24, 2023
@coufalja coufalja deleted the bug/respect-cfg-map-name-override branch October 24, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants