Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for ingress.host templating #153

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 24, 2023

Description of the change

In some cases it may be useful to allow ingress.host to be templated - for example if you want to reuse the same value in backstage.appConfig. In scenarios where Backstage chart is used as a subchart the only way to properly propagate templated values is through global scope (you can't reference ingress.host outside of the subchart). This PR should add support for such scenarios:

# values.yaml
global:
  foo: foo.bar
ingress:
  host: '{{ .Values.global.foo }}'
  enabled: true

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@tumido tumido merged commit 58edf6e into backstage:main Nov 24, 2023
3 checks passed
@tumido tumido deleted the template-ingress-host branch November 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants