feat: Adds TLS for Ingress #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJBurns
force-pushed
the
adds-tls-for-ingress
branch
from
a4bf708 to
7c727d0
Compare
4 tasks
tumido
requested changes
Dec 7, 2022
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
ChrisJBurns
force-pushed
the
adds-tls-for-ingress
branch
from
c1050b2 to
7e9077d
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds TLS Configuration for Ingress. Closes: #2
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.Have added the variables to the Values file and the
README.mdbut we don't usehelm-docsauto-generation at the moment. There was an open issue on this on the old backstage chart repo but we never actually implemented it. I feel we should raise a separate issue for this and track it separately.Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com