Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding configmap namespace #176

Closed
wants to merge 2 commits into from
Closed

adding configmap namespace #176

wants to merge 2 commits into from

Conversation

IronMage
Copy link

Description of the change

The Backstage App Config ConfigMap is created without a namespace defined.

Existing or Associated Issue(s)

None

Additional Information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@IronMage IronMage requested a review from a team as a code owner April 15, 2024 21:13
@nickboldt
Copy link
Contributor

@IronMage can you sign your commits with the -s flag when pushing into the pull request? that will get around the failed DCO check.

@ChrisJBurns
Copy link
Contributor

@IronMage When you re-push with a signed commit and meet all the checks, I can approve

@nickboldt
Copy link
Contributor

Replaced by #178 with correct DCO signoff, and more complete version bump / doc update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants