Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move dependencies to OCI registry #192

Merged
merged 3 commits into from
May 30, 2024
Merged

fix: move dependencies to OCI registry #192

merged 3 commits into from
May 30, 2024

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented May 11, 2024

Description of the change

Migrates to OCI Bitnami registry. Also temporarily locks the common and postgresql dependencies just so we can isolate the OCI registry change. The versions will be bumped in #191

Resolves: #190

@ChrisJBurns ChrisJBurns requested a review from a team as a code owner May 11, 2024 13:24
@ChrisJBurns ChrisJBurns changed the title fix: migrates to bitnami oci registry fix: chart dependency upgrade and OCI registry change May 11, 2024
@ChrisJBurns ChrisJBurns changed the title fix: chart dependency upgrade and OCI registry change fix: Move Dependencies to OCI Registry May 11, 2024
@ChrisJBurns ChrisJBurns changed the title fix: Move Dependencies to OCI Registry fix: move dependencies to OCI registry May 11, 2024
OCI is the Bitnami recommended registry to use as described in
https://blog.bitnami.com/2023/04/httpsblog.bitnami.com202304bitnami-helm-charts-now-oci.html.

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns force-pushed the uses-oci-bitnami-reg branch from 8d831b1 to 50709f9 Compare May 11, 2024 13:44
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns
Copy link
Contributor Author

@vinzscam Yep good point, can't believe I missed them! I removed from pipeline also so should get faster in that area too.

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Just a thought: Maybe we can also advice the end-user to use OCI for Backstage chart instead... 🤷 🙂

We publish to: oci://ghcr.io/backstage/charts/backstage

@ChrisJBurns
Copy link
Contributor Author

@tumido We have a section in the README.md for it, maybe we should put in bold letters saying its recommended due to the old non-OCI way being deprecated soon?

Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 30, 2024
@vinzscam vinzscam removed the stale label May 30, 2024
@vinzscam vinzscam merged commit d031441 into main May 30, 2024
3 checks passed
@vinzscam vinzscam deleted the uses-oci-bitnami-reg branch May 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OCI Bitnami Registry for Sub Charts
3 participants