-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move dependencies to OCI registry #192
Conversation
OCI is the Bitnami recommended registry to use as described in https://blog.bitnami.com/2023/04/httpsblog.bitnami.com202304bitnami-helm-charts-now-oci.html. Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
8d831b1
to
50709f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Shall we also update the two README.md
?
https://github.com/backstage/charts/blob/main/README.md?plain=1#L30
https://github.com/backstage/charts/blob/main/charts/backstage/README.md?plain=1#L34
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
@vinzscam Yep good point, can't believe I missed them! I removed from pipeline also so should get faster in that area too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Just a thought: Maybe we can also advice the end-user to use OCI for Backstage chart instead... 🤷 🙂
We publish to: oci://ghcr.io/backstage/charts/backstage
@tumido We have a section in the README.md for it, maybe we should put in bold letters saying its recommended due to the old non-OCI way being deprecated soon? |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Description of the change
Migrates to OCI Bitnami registry. Also temporarily locks the
common
andpostgresql
dependencies just so we can isolate the OCI registry change. The versions will be bumped in #191Resolves: #190