-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backstage): option to pass in image by digest #208
Conversation
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hey @1602077 any chance you could add a CI test to cover the digest addition? |
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
86228a1
to
c6320cd
Compare
Sure thing @ChrisJBurns - I have added now. Let me know if there is anything else you need from me. Cheers |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Hey @ChrisJBurns - I was unsure whether I need to assign any reviewers or not? |
Thanks @1602077 have approved, will see how the tests get on 🤞 |
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
apologies looks like I forgot to rerun the precommit hook after merge main - ci should pass now cheers |
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Description of the change
Add option to pass image tag by digest (i.e.
sha256:xxx
) instead of image tag. This makes use of already existing support in the bitnami common templates.Existing or Associated Issue(s)
Apologies as this is just updating the
values.yaml
file I haven't opened an issue.Additional Information
This is a common issue that gets flagged when auditing kubernetes manifests with tooling like
trivy
orcheckov
. If you need more detail let me know and I can add some examples to the PR description.Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.