Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backstage): option to pass in image by digest #208

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

1602077
Copy link
Contributor

@1602077 1602077 commented Jul 16, 2024

Description of the change

Add option to pass image tag by digest (i.e. sha256:xxx) instead of image tag. This makes use of already existing support in the bitnami common templates.

Existing or Associated Issue(s)

Apologies as this is just updating the values.yaml file I haven't opened an issue.

Additional Information

This is a common issue that gets flagged when auditing kubernetes manifests with tooling like trivy or checkov. If you need more detail let me know and I can add some examples to the PR description.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
@1602077 1602077 requested a review from a team as a code owner July 16, 2024 08:11
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jul 24, 2024
@ChrisJBurns
Copy link
Contributor

Hey @1602077 any chance you could add a CI test to cover the digest addition?

@github-actions github-actions bot removed the stale label Jul 28, 2024
Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
@1602077 1602077 force-pushed the feat/image-by-digest branch from 86228a1 to c6320cd Compare August 1, 2024 12:02
@1602077
Copy link
Contributor Author

1602077 commented Aug 1, 2024

Hey @1602077 any chance you could add a CI test to cover the digest addition?

Sure thing @ChrisJBurns - I have added now. Let me know if there is anything else you need from me.

Cheers

Copy link

github-actions bot commented Aug 9, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 9, 2024
@1602077
Copy link
Contributor Author

1602077 commented Aug 9, 2024

Hey @ChrisJBurns - I was unsure whether I need to assign any reviewers or not?

@github-actions github-actions bot removed the stale label Aug 10, 2024
@ChrisJBurns
Copy link
Contributor

Thanks @1602077 have approved, will see how the tests get on 🤞

Signed-off-by: 1602077 <62025739+1602077@users.noreply.github.com>
@1602077
Copy link
Contributor Author

1602077 commented Aug 14, 2024

Thanks @1602077 have approved, will see how the tests get on 🤞

apologies looks like I forgot to rerun the precommit hook after merge main - ci should pass now

cheers

Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 22, 2024
@ChrisJBurns ChrisJBurns merged commit 0aa17f4 into backstage:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants