Allow to customize the metrics port of the ServiceMonitor #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippeckelintive
force-pushed
the
main
branch
from
7a7eef2 to
c44e08b
Compare
tumido
reviewed
Oct 23, 2024
Member
tumido
left a comment
tumido
left a comment
There was a problem hiding this comment.
Just 2 minor suggestions, otherwise I like the change. 👍
fixes backstage#221 Signed-off-by: Philipp Eckel <philipp.eckel@intive.com>
philippeckelintive
force-pushed
the
main
branch
from
c44e08b to
b820880
Compare
Contributor
Author
|
@tumido thanks for the feedback. Please have a look again. |
|
Hey! Thanks about these changes. However, doesn't the OpenTelemetry port need to be exposed in https://github.com/backstage/charts/blob/main/charts/backstage/templates/backstage-deployment.yaml#L157-L160 ? |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
Description of the change
Allow to customize the metrics port of the ServiceMonitor, i.e. when using OpenTelemetry.
Existing or Associated Issue(s)
Additional Information
Currently, the metrics port in the ServiceMonitor is set to the http-backend port. When using OpenTelemetry as recommended with Prometheus exporter, this port needs to be different.
OpenTelemetry's default port for Prometheus exporter is 9464, but it can be customized.
So the chart should allow setting a custom port for the ServiceMonitor. The default value remains
http-backend.Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.