fix: Updates to jsonschema dereference script #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix linting errors when opening files without selecting an encoding - Search for values.schema.tmpl.json instead of Chart.lock files - Rename 'schema' variables to prevent shadowing or redefining - Add Module docstring - Add comments explaining what is being done - Rename file to follow Python module naming convention of snake_case - Rename some variables to correctly represent what they are doing, schema_template instead of chart, etc. - Update pre-commit to point to new jsonschema_dereference script name Signed-off-by: Corey Daley <cdaley@redhat.com>
|
@ChrisJBurns Thank you! |
coreydaley
deleted the
2024-11-23-jsonschema-dereference-script-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.