Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates to jsonschema dereference script #235

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Nov 23, 2024

Description of the change

  • Fix linting errors when opening files without selecting an encoding
  • Search for values.schema.tmpl.json instead of Chart.lock files
  • Rename 'schema' variables to prevent shadowing or redefining
  • Add Module docstring
  • Add comments explaining what is being done
  • Rename file to follow Python module naming convention of snake_case
  • Rename some variables to correctly represent what they are doing, schema_template instead of chart, etc.
  • Update pre-commit to point to new jsonschema_dereference script name

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

 - Fix linting errors when opening files without selecting an encoding
 - Search for values.schema.tmpl.json instead of Chart.lock files
 - Rename 'schema' variables to prevent shadowing or redefining
 - Add Module docstring
 - Add comments explaining what is being done
 - Rename file to follow Python module naming convention of snake_case
 - Rename some variables to correctly represent what they are doing, schema_template instead of chart, etc.
 - Update pre-commit to point to new jsonschema_dereference script name

Signed-off-by: Corey Daley <cdaley@redhat.com>
@coreydaley coreydaley requested a review from a team as a code owner November 23, 2024 18:09
Copy link
Contributor

@ChrisJBurns ChrisJBurns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ChrisJBurns ChrisJBurns merged commit 5129443 into backstage:main Nov 25, 2024
1 check passed
@coreydaley
Copy link
Contributor Author

@ChrisJBurns Thank you!

@coreydaley coreydaley deleted the 2024-11-23-jsonschema-dereference-script-fixes branch November 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants