Feature: Resource Limits for backstage container #27
Conversation
Why do we need this change? ======================= As per best practices we should enable/allow users to set both request and limits on their execution/running of the backstage app to ensure that it won't take up all resources for a node due to any potential memory leaks or run away cpu processes What effects does this change have? =======================
|
So I'm assuming a bit that #18 is just waiting on a touch of things and should update the docs automatically for this, but unclear what that might be waiting on. If we want to proceed with this I can update this and potentially that pr depending on desires. |
hey @JoshuaJackson-jobvite yeah, yesterday it was still missing approval from another maintainer and then it was waiting for me to get back to work today (since the culture in Backstage is to self-merge once approved for maintainers). It is merged now. 🙂 Can you please rebase and run |
… the readme via helm-docs. Keep in the example resources just so that folks have it in case of need
JoshuaJackson-jobvite
requested review from
tumido and
ChrisJBurns
and removed request for
tumido and
ChrisJBurns
… to modify that pr again
Description of the change
Adds support for setting requests and limits on the backstage deployment such that folks can execute to their desired best practices on resource consolidation.
Existing or Associated Issue(s)
#26
Additional Information
Looked over my local developer deployment that has a number of added plugins and a few charts etc and what the resource limits were. Set memory fairly high comparatively but cpu should be fully in line.
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.