Tolerations option

[chrisaq]

Description of the change

Add optional tolerations to the chart.

Existing or Associated Issue(s)

Additional Information

Not much to add here, it lets you choose which nodes in the cluster the containers are deployed to.

This is required in some cluster configurations.

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
• JSON Schema generated.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[tumido]

LGTM 👍

@chrisaq can you please rebase this and bump the chart version once more?

[chrisaq]

@tumido Is it ok now, or do you have any other suggestions?

[tumido]

@chrisaq nope, your code looks good to me. 🙂 Now we just need it to pass CI, please check on the README.md and either run pre commit or see the diff at https://github.com/backstage/charts/actions/runs/3939323538/jobs/6739330501 . 🙂

[chrisaq]

@chrisaq nope, your code looks good to me. slightly_smiling_face Now we just need it to pass CI, please check on the README.md and either run pre commit or see the diff at https://github.com/backstage/charts/actions/runs/3939323538/jobs/6739330501 . slightly_smiling_face

@tumido Thanks, I left in a double entry in the README which I removed, so I believe the CI should pass now.

[chrisaq]

@tumido Sorry to bother you again.
It seems to fail on something generated from the updated semver, but it is not obvious to me why changing the number from 13 to 14 would trigger this.
Any ideas?

[tumido]

@chrisaq no worries. 🙂

Your PR is changing the chart version to 0.14.0 https://github.com/backstage/charts/pull/47/files#diff-8316e61c38ae132c31764bc73c703fefb6bfe57770e77aa97e63c0f9f490a1fcR18 . This change needs to be reflected in the README.md as well:

-![Version: 0.13.0](https://img.shields.io/badge/Version-0.13.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 0.14.0](https://img.shields.io/badge/Version-0.14.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

We want the README to display current data, not the previous version 🙂

If you want, you can get the README.md re-generated on the fly before each commit - you can do so by installing pre-commit as a git hook (via pre-commit install).

[tumido]

/lgtm
/approve

[chrisaq]

Just cleaned up the commit log, thanks for the pre-commit tip.

[tumido]

@chrisaq sigh.. there seems to be one last issue. 😕 It won't allow me to merge your PR unless your commit is signed.

https://docs.github.com/articles/about-gpg/

Can you please look into that?

[chrisaq]

@tumido Thank you for your continued patience.
I did a commit with -s and now it says it's signed-off by me, does it match the requirements?
-- nevermind, I see it's still marked as blocked below, I'll try to figure it out.

[chrisaq]

@tumido seems green here now!