feat: allow setting podAnnotations #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
requested changes
Jan 26, 2023
There was a problem hiding this comment.
Hey @alexef! Thank you for contributing! 🙂
I would prefer to see the value listed under .backstage root key. WDYT? See the inline comment above.
Also once all the changes are done, can an you please run:
# either
pre-commit run -a
# or
helm-docs --chart-search-root=charts --template-files=./_templates.gotmpl --template-files=README.md.gotmplThis will make the README.md changes to align with our README template.
|
@alexef unfortunately I can't merge this, unless your commits are signed. Can you please look into that?
|
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
4 tasks
vinzscam
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
We use them in combinations with KIAM to allow the pod to assume a IAM role
Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.