Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodeSelector to deployment template #73

Merged
merged 2 commits into from
Mar 25, 2023
Merged

add nodeSelector to deployment template #73

merged 2 commits into from
Mar 25, 2023

Conversation

enmuro
Copy link
Contributor

@enmuro enmuro commented Mar 24, 2023

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@enmuro enmuro marked this pull request as ready for review March 24, 2023 13:55
@enmuro enmuro requested a review from a team as a code owner March 24, 2023 13:55
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Overall, LGTM. 👍 🙂 I have one suggestion though. See inline ^

charts/backstage/templates/backstage-deployment.yaml Outdated Show resolved Hide resolved
enoe-mugnaschi-edo and others added 2 commits March 24, 2023 21:11
Signed-off-by: Enoe Mugnaschi <enoe.mugnaschi@edreamsodigeo.com>
Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com>
Signed-off-by: Enoe Mugnaschi <enoe.mugnaschi@edreamsodigeo.com>
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Nicely done, thank you! 👍

@tumido tumido merged commit 709fe4d into backstage:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants