feat: add additional annotations to Deployment #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tumido
force-pushed
the
deployment-annotations
branch
from
ab7f59c to
7a9edfd
Compare
vinzscam
approved these changes
Apr 4, 2023
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
tumido
force-pushed
the
deployment-annotations
branch
from
7a9edfd to
9058bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In addition to
backstage.podAnnotationsandcommonAnnotationswe want to have something specific to theDeploymentresource. In case we want to annotateDeploymentthecommonAnnotationsvalue is too noisy andbackstage.podAnnotationsis not really being set on theDeploymentitself.Other resources deployed by this chart have their own specific chart value for annotations (
service.annotations,ingress.annotations, etc...).Existing or Associated Issue(s)
N/A
Additional Information
@backstage/helm-charts and @backstage/helm-charts-maintainers wdyt? Does it make sense to have yet another annotation value in the chart? Should I propagate this
backstage.annotationsvalue to the pod as well?Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.