[Linguist] Marked createRouter, createRouterFromConfig, RouterOptions, and PluginOptions as deprecated
#1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
|
Seems to be a conflict here, otherwise LGTM |
… `PluginOptions` as deprecated Signed-off-by: Andre Wanlin <awanlin@spotify.com>
awanlin
force-pushed
the
topic/linguist-deprecate-createrouter
branch
from
df7f2a9 to
7adad4a
Compare
|
Conflict fixed up, just needs approval, please? |
BethGriggs
approved these changes
Sep 16, 2024
Eswaraiahsapram
pushed a commit
to Eswaraiahsapram/community-plugins
that referenced
this pull request
Sep 17, 2024
…outerOptions`, and `PluginOptions` as deprecated (backstage#1198) Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Eswaraiahsapram
added a commit
to Eswaraiahsapram/community-plugins
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Eswaraiahsapram <esapram@redhat.com> fix(deps): update dependency dompurify to v3.1.3 [security] (backstage#1231) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> workspace(tech-insights): added support for links to tech-insight checks (backstage#1203) This includes UI components to render a popup menu with these links, by default on the result icon in the scorecards view. Signed-off-by: Gustaf Räntilä <g.rantila@gmail.com> fix(deps): update dependency body-parser to v1.20.3 [security] (backstage#1206) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> plugin(linguist): marked `createRouter`, `createRouterFromConfig`, `RouterOptions`, and `PluginOptions` as deprecated (backstage#1198) Signed-off-by: Andre Wanlin <awanlin@spotify.com> addressed review comments for argo resources timestamp Signed-off-by: Eswaraiahsapram <esapram@redhat.com>
Eswaraiahsapram
added a commit
to Eswaraiahsapram/community-plugins
that referenced
this pull request
Sep 19, 2024
# This is the 1st commit message: fetching resources timestamp from k8s object Signed-off-by: Eswaraiahsapram <esapram@redhat.com> fix(deps): update dependency dompurify to v3.1.3 [security] (backstage#1231) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> workspace(tech-insights): added support for links to tech-insight checks (backstage#1203) This includes UI components to render a popup menu with these links, by default on the result icon in the scorecards view. Signed-off-by: Gustaf Räntilä <g.rantila@gmail.com> fix(deps): update dependency body-parser to v1.20.3 [security] (backstage#1206) Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com> plugin(linguist): marked `createRouter`, `createRouterFromConfig`, `RouterOptions`, and `PluginOptions` as deprecated (backstage#1198) Signed-off-by: Andre Wanlin <awanlin@spotify.com> addressed review comments for argo resources timestamp Signed-off-by: Eswaraiahsapram <esapram@redhat.com> # This is the commit message backstage#2: fetched argo resources timestamp from k8s object Signed-off-by: Eswaraiahsapram <esapram@redhat.com> fetched argo resources timestamp from k8s object Signed-off-by: Eswaraiahsapram <esapram@redhat.com> fetched argo resources timestamp from k8s object Signed-off-by: Eswaraiahsapram <esapram@redhat.com>
karthikjeeyar
pushed a commit
to karthikjeeyar/community-plugins
that referenced
this pull request
Oct 28, 2024
…outerOptions`, and `PluginOptions` as deprecated (backstage#1198) Signed-off-by: Andre Wanlin <awanlin@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Marked
createRouter,createRouterFromConfig,RouterOptions, andPluginOptionsas deprecated, to be removed soon after the Backstage1.32.0release in October✔️ Checklist
Signed-off-byline in the message. (more info)