chore(topology): migrate to MUI v5 #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
ciiay
force-pushed
the
upgrade-to-mui-5-for-topology
branch
from
a939818 to
73df44e
Compare
awanlin
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Hi @ciiay, I know this is Draft (it was before I hit submit 😆) but wanted to share a few comments based on my experience.
Just in case you have not seen it here's the migration tutorial: https://backstage.io/docs/tutorials/migrate-to-mui5
workspaces/topology/packages/app/src/components/catalog/EntityPage.tsx
Outdated
Show resolved
Hide resolved
ciiay
force-pushed
the
upgrade-to-mui-5-for-topology
branch
4 times, most recently
from
657c30e to
eaaf1df
Compare
|
Hi @awanlin , I have addressed your comments. I figured I would need your confirmation to merge this PR right? |
|
Hi @ciiay, I didn't actually review it, it was still Draft when I was looking at it, but wanted to share my experiences. I'm happy to review it but I won't have time until Friday. |
|
@nickboldt seeing as I started with this one I'll take it end-to-end. |
ciiay
force-pushed
the
upgrade-to-mui-5-for-topology
branch
2 times, most recently
from
d5e5c1e to
3836f65
Compare
awanlin
requested changes
Oct 23, 2024
workspaces/topology/packages/app/src/components/catalog/EntityPage.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
force-pushed
the
upgrade-to-mui-5-for-topology
branch
2 times, most recently
from
0382895 to
40bb466
Compare
Signed-off-by: Yi Cai <yicai@redhat.com>
ciiay
force-pushed
the
upgrade-to-mui-5-for-topology
branch
from
40bb466 to
2143582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR is for topology plugin to migrate to MUI v5.
✔️ Checklist
Signed-off-byline in the message. (more info)