Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linguist - Migrated to MUI v5 #1806

Closed

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Oct 31, 2024

Hey, I just made a Pull Request!

Migrated to using MUI v5

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-linguist workspaces/linguist/plugins/linguist patch v0.1.28

@awanlin
Copy link
Contributor Author

awanlin commented Oct 31, 2024

Have this up as as Draft as I'm running into the following error: "TypeError: theme.spacing is not a function". I'm not sure how to fix this right now so could use some help. 🤔

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
@freben
Copy link
Member

freben commented Nov 4, 2024

What happens if you do not have the explicit Theme type in makeStyles((theme: Theme)?

@awanlin awanlin closed this Nov 18, 2024
@awanlin awanlin deleted the topic/migrate-linguist-to-mui-5 branch November 18, 2024 01:58
@awanlin awanlin restored the topic/migrate-linguist-to-mui-5 branch November 18, 2024 01:58
@awanlin awanlin deleted the topic/migrate-linguist-to-mui-5 branch November 20, 2024 19:06
@awanlin
Copy link
Contributor Author

awanlin commented Nov 28, 2024

Won't be moving forward with this until the following RFC is settled: backstage/backstage#27726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants